| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Jeff Davis <pgsql(at)j-davis(dot)com> |
| Subject: | Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version() |
| Date: | 2026-03-02 18:36:20 |
| Message-ID: | 262909b8-3f4b-42ce-acd7-bdd4a6897990@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27.02.26 07:45, Bertrand Drouvot wrote:
> Hi,
>
> On Fri, Feb 27, 2026 at 02:04:30PM +0800, Chao Li wrote:
>>
>>
>> What I'm interested in is the broader policy: when reviewing patches,
>> if we encounter a foo() declaration, should we consistently request a change to foo(void)?
>> If yes, the standard should be documented somewhere.
>
> I think that they should be consistently fixed for the reasons mentioned in
> [1], and that the best way to achieve this goal would be to enable -Wstrict-prototypes
> by default ([2]).
Yes, why not add -Wstrict-prototypes and perhaps -Wold-style-definition
to the standard warnings. Then we don't have to keep chasing these
manually.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexandre Felipe | 2026-03-02 18:45:03 | Re: index prefetching |
| Previous Message | Andrew Dunstan | 2026-03-02 18:25:08 | Re: meson: Make test output much more useful on failure (both in CI and locally) |