Re: pgsql: Allow pg_basebackup to stream transaction log in tar mode

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Allow pg_basebackup to stream transaction log in tar mode
Date: 2016-10-23 15:48:09
Message-ID: 26273.1477237689@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> The remaining windows buildfarm build issue looks like this:
> src/bin/pg_basebackup/receivelog.c(135): error C2039: '_commit' : is
> not a member of 'WalWriteMethod'
> [C:\buildfarm\buildenv\HEAD\pgsql.build\pg_basebackup.vcxproj]
> AFAICT this comes from using walmethod->fsync(), and we have a #define
> changing fsync() to _commit (port/win32.h, line 70).

Yeah.

> The easiest might just be to rename walmethod->fsync() to
> walmethod->do_fsync(), so we don't have to mess with any other code.

How about calling the method just "sync()"? Seems a bit less
artificial.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2016-10-23 16:03:06 Re: pgsql: Allow pg_basebackup to stream transaction log in tar mode
Previous Message Magnus Hagander 2016-10-23 14:09:09 pgsql: Fix obviously too quickly applied fix to zlib issue