| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Why are we PageInit'ing buffers in RelationAddExtraBlocks()? |
| Date: | 2019-01-28 23:08:59 |
| Message-ID: | 26263.1548716939@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> I'm inclined to put back the
> LockBuffer(buf, BUFFER_LOCK_UNLOCK);
> LockRelationForExtension(onerel, ExclusiveLock);
> UnlockRelationForExtension(onerel, ExclusiveLock);
> LockBufferForCleanup(buf);
> if (PageIsNew(page))
> dance regardless, just to get the buildfarm to green?
The buildfarm's got half a dozen reports now of a failure of this ilk,
so you'd better do something.
> But I do wonder if we should just make hio.c cope with this instead.
Probably should not try to go that way under time presssure.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Glukhov | 2019-01-28 23:18:23 | Re: jsonpath |
| Previous Message | Tom Lane | 2019-01-28 23:04:29 | Re: "SELECT ... FROM DUAL" is not quite as silly as it appears |