| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Christian Ullrich <chris(at)chrullrich(dot)net>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: VS 2015 support in src/tools/msvc |
| Date: | 2016-04-29 04:39:32 |
| Message-ID: | 26249.1461904772@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> latest patch attached. I have also cleaned up the docs some, and removed
> references to the now redundant msysGit.
Please don't do stuff like this:
@@ -232,6 +265,10 @@ win32_langinfo(const char *ctype)
if (r != NULL)
sprintf(r, "CP%s", codepage);
}
+
+#if (_MSC_VER >= 1900)
+ }
+#endif
#endif
return r;
I'm not very sure what pgindent will do with conditionally-included
indentation, but it's unlikely to be pleasing.
In this particular case, you could probably fix it by making the
other end of that be
+ if (GetLocaleInfoEx(wctype,
+ LOCALE_IDEFAULTANSICODEPAGE | LOCALE_RETURN_NUMBER,
+ (LPWSTR) &cp, sizeof(cp) / sizeof(WCHAR)) > 0)
+ {
+ r = malloc(16); /* excess */
+ if (r != NULL)
+ sprintf(r, "CP%u", cp);
+ }
+ else
+#endif
+ {
+
and omitting the #if/#endif around the trailing }.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | sri harsha | 2016-04-29 05:42:40 | Re: UNION ALL - Var attno |
| Previous Message | Tom Lane | 2016-04-29 04:33:32 | Re: UNION ALL - Var attno |