Re: The return value of SPI_connect

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: The return value of SPI_connect
Date: 2020-09-28 14:02:31
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

"Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> writes:
> May be we can make "int SPI_connect()" => "void SPI_connect()" and fix the doc ?

I don't see a lot of value in changing SPI_connect() in isolation.
It's part of an API suite that generally expects functions to
return error codes.

There was a previous thread [1] about getting rid of useless SPI
error codes across the board, in favor of having those functions
throw errors for error cases. AFAICT nobody has reviewed the
proposed patch there, but maybe you'd like to?

regards, tom lane


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-09-28 14:18:17 Re: Skip ExecCheckRTPerms in CTAS with no data
Previous Message Alvaro Herrera 2020-09-28 13:56:10 Re: a problem about XLogReader callback system