| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Jelte Fennema <postgres(at)jeltef(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: run pgindent on a regular basis / scripted manner |
| Date: | 2023-10-17 00:45:00 |
| Message-ID: | 2620572.1697503500@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> There were two independent fixup commits to address complaints from
> koel just today (from two different committers). Plus there was a
> third issue (involving a third committer) this past Wednesday.
> This policy isn't working.
Two thoughts about that:
1. We should not commit indent fixups on behalf of somebody else's
misindented commit. Peer pressure on committers who aren't being
careful about this is the only way to improve matters; so complain
to the person at fault until they fix it.
2. We could raise awareness of this issue by adding indent verification
to CI testing. I hesitate to suggest that, though, for a couple of
reasons:
2a. It seems fairly expensive, though I might be misjudging.
2b. It's often pretty handy to submit patches that aren't fully
indent-clean; I have such a patch in flight right now at [1].
2b could be ameliorated by making the indent check be a separate
test process that doesn't obscure the results of other testing.
regards, tom lane
[1] https://www.postgresql.org/message-id/2617358.1697501956%40sss.pgh.pa.us
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2023-10-17 01:17:11 | Re: Fix output of zero privileges in psql |
| Previous Message | Tom Lane | 2023-10-17 00:19:16 | Allow ALTER SYSTEM SET on unrecognized custom GUCs |