| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
| Cc: | itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: pgbench on mingw needs fflush |
| Date: | 2007-03-13 07:56:31 |
| Message-ID: | 26178.1173772591@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> writes:
> Can we distinguish mingw case from others so that we could ifdef out
> the extra fflush()?
Isn't the right fix a single-spot patch to force stderr into unbuffered
mode? It's supposed to be that way already per spec. I could see a
one-or-two-line patch to remind mingw of the buffer mode it's supposed
to be using ... I'm not excited about making an ongoing commitment to
remember to fflush() after every write call, especially not when no
standard-compliant platform needs it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-03-13 08:05:37 | Re: guc patch: Make variables fall back to default values |
| Previous Message | Peter Eisentraut | 2007-03-13 07:39:31 | Re: guc patch: Make variables fall back to default values |