Re: avg(int2) and avg(int8) micro-opt

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: avg(int2) and avg(int8) micro-opt
Date: 2005-04-04 15:21:50
Message-ID: 26163.1112628110@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> This patch changes int2_avg_accum() and int4_avg_accum() use the nodeAgg
> performance hack Tom introduced recently.

Why only those two? Might as well make all the accum functions look alike.

> It is possible that the transition array might be TOAST'ed (not that I'd
> expect that to occur in practice, of course).

AFAICS that is impossible, since the transition value is never stored to
disk. But your analysis is good anyway.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-04-04 15:42:33 Re: DELETE ... USING
Previous Message Christopher Kings-Lynne 2005-04-04 14:17:40 Re: Bug in DROP NOT NULL