Re: Proposal: More structured logging

From: Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Proposal: More structured logging
Date: 2022-01-17 08:18:04
Message-ID: 2614931.mvXUDI8C0e@aivenronan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Le samedi 15 janvier 2022, 07:09:59 CET Julien Rouhaud a écrit :
> Hi,
> On Tue, Jan 11, 2022 at 11:05:26AM +0100, Ronan Dunklau wrote:
> > Done, and I added anoher commit per your suggestion to add this comment.
> The cfbot reports that the patchset doesn't apply anymore:
> === Applying patches on top of PostgreSQL commit ID
> 43c2175121c829c8591fc5117b725f1f22bfb670 === [...]
> === applying patch ./v4-0003-Output-error-tags-in-CSV-logs.patch
> [...]
> patching file src/backend/utils/error/elog.c
> Hunk #2 FAILED at 3014.
> 1 out of 2 hunks FAILED -- saving rejects to file
> src/backend/utils/error/elog.c.rej
> Could you send a rebased version? In the meantime I will switch the cf
> entry to Waiting on Author.

Thank you for this notification !

The csvlog has been refactored since I wrote the patch, and the new jsonlog
destination has been introduced. I rebased to fix the first patch, and added a
new patch to add support for tags in jsonlog output.

Best regards,

Ronan Dunklau

Attachment Content-Type Size
v5-0001-Add-ErrorTag-support.patch text/x-patch 4.0 KB
v5-0002-Add-test-module-for-the-new-tag-functionality.patch text/x-patch 6.6 KB
v5-0003-Output-error-tags-in-CSV-logs.patch text/x-patch 1.3 KB
v5-0005-Add-error-tags-to-json-output.patch text/x-patch 1.3 KB
v5-0004-Add-comment-in-config.sgml-as-a-reminder-to-also-.patch text/x-patch 889 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-01-17 08:24:43 Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Previous Message 2022-01-17 08:03:17 RE: Skipping logical replication transactions on subscriber side