Re: Cause of recent buildfarm failures on hamerkop

Aidan Van Dyk <aidan(at)highrise(dot)ca> writes:
> If we have "text files" that we need to be "binary equivilents" for
> the purpose of diffing, we should probably attribute them in git
> attributes to make sure they are not considered "text autocrlf'able".
> It could be as simple as adding:
> *.out -text
> *.data -text
> *.source -text
> into src/test/regress/.gitattributes

Oh, hold the phone. We don't need to do that. When I went and looked,
I realized that there *already is* a variant file largeobject_1.source
that's meant to provide matching output for DOS-ified source files.
The reason that hamerkop has been failing since commit
3a0e4d36ebd7f477822d5bae41ba121a40d22ccc is that that commit changed
the largeobject test and did not bother to update all the corresponding
expected files. Boo hiss.

I went ahead and put in the length query, in hopes that the problem will
be a little more obvious next time this happens.

regards, tom lane