Re: ALTER DATABASE RESET with unexistent guc doesn't report an error

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER DATABASE RESET with unexistent guc doesn't report an error
Date: 2025-09-12 22:12:47
Message-ID: 2612308.1757715167@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Looking at the patch, the delta in database.out raises
> another question:
> ALTER DATABASE regression_tbd RENAME TO regression_utf8;
> ALTER DATABASE regression_utf8 SET TABLESPACE regress_tblspace;
> ALTER DATABASE regression_utf8 RESET TABLESPACE;
> +ERROR: unrecognized configuration parameter "tablespace"
> ALTER DATABASE regression_utf8 CONNECTION_LIMIT 123;
> The author of this bit of test script evidently thought that
> ALTER ... RESET TABLESPACE is the inverse of ALTER ... SET TABLESPACE,
> and what we are seeing is that it is not. That may be a bug in
> itself, but it's not what Vitaly is on about, IIUC.

That was in fact a test bug, now corrected at 4adb0380b.
I've substituted a more on-point test case, wordsmithed the
comment a little bit, and pushed it.

Thanks for the report and patch!

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2025-09-12 22:34:04 Re: RFC: extensible planner state
Previous Message Jeff Davis 2025-09-12 21:43:31 Re: PostgreSQL 18 GA press release draft