Re: pgsql: Fix "base" snapshot handling in logical decoding

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix "base" snapshot handling in logical decoding
Date: 2018-06-29 03:53:10
Message-ID: 26020.1530244390@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Fix "base" snapshot handling in logical decoding

According to buildfarm member friarbird, and as confirmed here,
the contrib/test_decoding/specs/oldest_xmin.spec test added by this
commit fails under CLOBBER_CACHE_ALWAYS.

friarbird's error output doesn't seem to be getting captured by the
buildfarm script, but what I see is

***************
*** 16,21 ****
--- 16,22 ----

step s1_commit: COMMIT;
step s0_vacuum: VACUUM FULL;
+ ERROR: canceling statement due to user request
step s0_get_changes: SELECT data FROM pg_logical_slot_get_changes('isolation_s
lot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1');
data

which looks like it might just be a timeout problem.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2018-06-29 09:13:28 Re: pgsql: Clarify use of temporary tables within partition trees
Previous Message Michael Paquier 2018-06-29 00:46:31 pgsql: Make capitalization of term "OpenSSL" more consistent

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-06-29 04:14:16 Re: partition tree inspection functions
Previous Message Jeff Janes 2018-06-29 03:15:54 Re: Make deparsing of column defaults faster