From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
Cc: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org, kyzevan23(at)mail(dot)ru |
Subject: | Re: BUG #16329: Valgrind detects an invalid read when building a gist index with buffering |
Date: | 2023-03-30 11:47:29 |
Message-ID: | 2601.1680176849@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Alexander Lakhin <exclusion(at)gmail(dot)com> writes:
> As to that concrete place, I would incline to improve the test while it stays
> in line with other tests, but I lack a whole picture of the gist testing.
> It doesn't seem to me that the regress/sql/gist.sql is too comprehensive.
> I've just looked at the scan-build's results and found 9 warnings related to
> gist. A quick glance at the code confirms that there are indeed
> interesting cases, which are not exercised for now (e.g., call
> gistRelocateBuildBuffersOnSplit() with
> IndexRelationGetNumberOfKeyAttributes(r) > 1).
> So if I could prove that 2-3 of them are really bugs during the next week,
> maybe then assess that test change alongside with others (if any).
> (Maybe we'll want to build that index over different columns, for example.)
OK, there's certainly no urgency.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2023-03-30 15:35:03 | Re: BUG #17876: Function width_bucket() for float8 input returns value out of range |
Previous Message | David Rowley | 2023-03-30 10:54:15 | Re: BUG #17879: ERROR: unrecognized node type: 2139062143 |