Why --backup-and-modify-in-place in perltidy config?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Why --backup-and-modify-in-place in perltidy config?
Date: 2016-08-14 20:38:36
Message-ID: 25994.1471207116@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I did a trial run following the current pgindent README procedure, and
noticed that the perltidy step left me with a pile of '.bak' files
littering the entire tree. This seems like a pretty bad idea because
a naive "git add ." would have committed them. It's evidently because
src/tools/pgindent/perltidyrc includes --backup-and-modify-in-place.
Is there a good reason for that, and if so what is it?

Also, is there a reason why the perltidy invocation command hasn't
been packaged into a shell script, rather than expecting the committer
to copy-and-paste a rather large string?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Joseph Krogh 2016-08-14 20:47:04 Re: Bogus ANALYZE results for an otherwise-unique column with many nulls
Previous Message Ryan Murphy 2016-08-14 19:38:02 Small patch: initdb: "'" for QUOTE_PATH (non-windows)