Re: roundoff problem in time datatype

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: roundoff problem in time datatype
Date: 2005-10-13 20:53:16
Message-ID: 2598.1129236796@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Where are we on this?

We haven't decided what to do.

I think my preference is to allow '24:00:00' (but not anything larger)
as a valid input value of the time datatypes. This for two reasons:
* existing dump files may contain such values
* it's consistent with allowing, eg, '12:13:60', which we
allow even though it's certainly not a valid leap second.

The alternative is to try to catch all places where 23:59:59.something
could get rounded up to 24:00:00, but that looks messy, and it would
introduce a gotcha into calculations on time values.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-10-13 20:53:55 Re: roundoff problem in time datatype
Previous Message Bruce Momjian 2005-10-13 20:48:01 Re: roundoff problem in time datatype

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-10-13 20:53:55 Re: roundoff problem in time datatype
Previous Message Bruce Momjian 2005-10-13 20:50:09 Re: SQL/XML publishing function experimental patch II