| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Pavel Raiskup <praiskup(at)redhat(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Devrim GÜNDÜZ <devrim(at)gunduz(dot)org> |
| Subject: | Re: plruby: rb_iterate symbol clash with libruby.so |
| Date: | 2018-11-07 14:25:31 |
| Message-ID: | 25954.1541600731@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pavel Raiskup <praiskup(at)redhat(dot)com> writes:
> On Tuesday, November 6, 2018 7:28:21 PM CET Tom Lane wrote:
>> Done. I realized that the immediate problem, rb_iterate(), was only
>> added as of PG v10, which may explain why we hadn't heard complaints
>> about this till now. So I've made the change only as far back as v10.
> The 'rb_iterate' seems to exist at least in REL9_2_STABLE branch, so it is
> probably much older.
Oh! Hmm ... I think I jumped to conclusions when the part of my patch
that touched struct RBTreeIterator failed to apply. But you're right,
rb_iterate has been there since 9.0 now that I look more carefully.
So we really ought to back-patch further. However:
> That
> said, I'm still not sure how this could work before ... Maybe it has not
> been working for some time.
Yeah, I'm now mighty confused about this as well. PL/Ruby is pretty old
too, so how come nobody noticed this before? Is its rb_iterate call in
someplace that hardly gets any use?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-07 14:30:37 | Re: pread() and pwrite() |
| Previous Message | Arthur Zakirov | 2018-11-07 14:11:39 | Re: fix psql \conninfo & \connect when using hostaddr |