Re: [PATCHES] binary operators on integers

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Marko Kreen <marko(at)l-t(dot)ee>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] binary operators on integers
Date: 2000-10-24 21:30:39
Message-ID: 25906.972423039@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> This patch was installed, with xor as "#". The parser still needs work.
> Besides the known issue of "|", this also parses funny:

> => select 5 & ~ 6;
> ERROR: Unable to identify a right operator '&' for type 'int4'

I think we're kind of stuck on that, at least in terms of a solution
specifically for ~ --- I don't think we should be wiring knowledge of
whether specific operators are prefix/suffix/infix into the grammar.

It might perhaps be possible to tweak the grammar so that

operand operator operator operand

is generically resolved as

operand infix-op (prefix-op operand)

and not

(operand postfix-op) infix-op operand

the way it is now. Given that postfix operators are relatively seldom
used, this seems a more sensible default --- but I suppose somewhere out
there is an application that will break. (At least it probably won't
break silently.)

Comments anyone?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-10-24 22:04:01 Bogus-looking SSL code in postmaster wait loop
Previous Message Tom Lane 2000-10-24 21:23:47 Re: Re: how to access backend pid from libpq ?

Browse pgsql-patches by date

  From Date Subject
Next Message Mike Castle 2000-10-25 17:33:26 minor doc patch
Previous Message Bruce Hartzler 2000-10-24 21:16:41 Re: [PATCHES] add darwin/osxpb support to cvs