Re: pgbench: Skipping the creating primary keys after initialization

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench: Skipping the creating primary keys after initialization
Date: 2017-08-02 13:41:58
Message-ID: 25904.1501681318@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Aug 1, 2017 at 9:49 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> I'd like to propose a new option -I for pgbench command which skips
>> the creating primary keys after initialized tables.

> I support adding an option for this, but I propose that we just make
> it a long-form option, similar to --log-prefix or --index-tablespace.

I think we could probably do without this ... if you want a non-default
test setup, why do you need to use "pgbench -i" to create it?

It's not that there's anything greatly wrong with this particular idea,
it's just that pgbench has too many switches already, and omitting random
subsets of the initialization actions doesn't seem like it contributes
fundamental new benchmarking capability.

I could get behind a proposal that generalized pgbench's "-i" behavior
in some meaningful way. I wonder whether it would be possible to convert
that behavior into a script. Some of what it does is just SQL commands
with injected parameters, which pgbench does already. There's also
data-loading actions, which could be converted to backslash commands
perhaps. Then desires like this could be addressed by invoking a
customized script instead of complicating pgbench's option set.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2017-08-02 13:56:29 Re: pgbench: Skipping the creating primary keys after initialization
Previous Message Masahiko Sawada 2017-08-02 13:38:19 Re: pgbench: Skipping the creating primary keys after initialization