Re: NLS on MSVC strikes back!

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Gevik Babakhani <pgdev(at)xs4all(dot)nl>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: NLS on MSVC strikes back!
Date: 2008-02-12 15:09:16
Message-ID: 25841.1202828956@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On Nov 24 2006 this was committed dor src/backend/utils/adt/formatting.c:

> r 1.114: Fix to_char() locale handling to honor LC_TIME, not LC_MESSAGES.

> A few hours later it was supposedly reverted: r 1.115: Revert (too late
> in beta): Fix to_char() locale handling to honor LC_TIME, not LC_MESSAGES.

> Apparently this was never returned to (it should probably have been put
> on the patches hold queue).

to_char's month/day name localization is implemented with gettext() not
strftime(), which is why it depends on LC_MESSAGES not LC_TIME. I seem
to recall that we didn't like the side-effects of the patch you are
mentioning, and so it ended up being rejected outright.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-02-12 15:14:50 Re: Mailing archive URL stability
Previous Message Bruce Momjian 2008-02-12 15:04:42 Re: Mailing archive URL stability