Re: Removing useless \. at the end of copy in pgbench

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Removing useless \. at the end of copy in pgbench
Date: 2018-07-28 01:52:08
Message-ID: 25801.1532742728@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> writes:
> While populating pgbench_account table by using COPY FROM STDIN,
> pgbench sends out "\." at the end of the copy data. However this is
> only necessary in the version 2 of frontend/backend protocol (i.e. the
> version 3 protocol does not need it). I think we can safely remove the
> code to save a few CPU cycle since we only support back to PostgreSQL
> 9.3 and the version 3 protocol has been supported since 7.4.

What exactly is the benefit of breaking compatibility with old servers?
Saving a few cycles during initial table population seems like it could
not be of interest to anyone.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2018-07-28 01:54:43 Re: Speeding up INSERTs and UPDATEs to partitioned tables
Previous Message Tatsuo Ishii 2018-07-28 01:23:12 Removing useless \. at the end of copy in pgbench