Re: pgsql: Invalidate RI fast-path metadata on operator family changes

Amit Langote <amitlangote09(at)gmail(dot)com> writes:
> Added pgsql-release. For context: the change is regression-test-only.
> It wraps the operator-family test added by c62b330912e in a
> rolled-back transaction so the family is never visible to concurrently
> running tests, which has been causing intermittent plan-shape failures
> in window.sql and equivclass.sql on several buildfarm animals (six in
> the last ~24h as Tom noted).
> Patch I would like to push is attached. I'd like concurrence to push
> it to REL_19_STABLE during the freeze.

To add to that: we've got about 40 hours before the 19beta4 wrap.
Given that these buildfarm failures are intermittent, that's already
not enough time to be 100% sure that the patch fixes them --- I think
it will, but perhaps not. However, the worst-case outcome is that
this makes things visibly worse, in which case we could revert it
sometime Monday and be no worse off than we are now. So my vote is
to go ahead, and not be too slow about that.

regards, tom lane