| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: pageinspect: Try to fix some bugs in previous commit. |
| Date: | 2017-02-03 17:04:48 |
| Message-ID: | 25729.1486141488@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> So based on that theory, here's a patch.
> ...
> In short, this patch makes hashfuncs.c consistent about (1) using the
> next wider signed type to report unsigned values and (2) using the
> GetDatum macro that matches the SQL return type in width and
> signedness. Objections?
I haven't actually reviewed the patch, but your description of it sounds
sane.
One thing to think about is what will happen if someday we want to use
64-bit hash codes (a day I think is not that far away). It sounds like
you've already chosen bigint for any output field that represents a
hash code or a related value such as a mask ... but it wouldn't hurt
to look through the fields with that in mind.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2017-02-03 18:18:44 | pgsql: Be sure to release LogicalRepLauncherLock in DROP SUBSCRIPTION c |
| Previous Message | Tom Lane | 2017-02-03 16:36:25 | Re: [COMMITTERS] pgsql: pageinspect: Try to fix some bugs in previous commit. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-02-03 17:10:35 | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
| Previous Message | Alexander Korotkov | 2017-02-03 17:01:03 | LWLock optimization for multicore Power machines |