| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Use asynchronous connect API in libpqwalreceiver |
| Date: | 2017-03-17 19:06:14 |
| Message-ID: | 25726.1489777574@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
I wrote:
> Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> writes:
>> Thanks, now that I look at it again I think we might need to do cycle
>> with the occurred_events and returned_events and not return on first
>> find since theoretically there can be multiple sockets if this gets
>> called directly and not via WaitLatchOrSocket(). I don't have mental
>> power to finish it up right now though, sorry for that.
> I think WaitEventSet is only required to identify at least one reason
> for ending the wait; it is not required to identify all of them.
Also, I see the header comment for the Windows version of
WaitEventSetWaitBlock says it really only ever reports one event anyway.
So there seems no need to work harder than this. Pushed with cosmetic
adjustments.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2017-03-18 09:35:56 | pgsql: Fix schedule of ecpg test files to only try two-phase commit tes |
| Previous Message | Tom Lane | 2017-03-17 19:04:12 | Re: [COMMITTERS] pgsql: Use asynchronous connect API in libpqwalreceiver |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-03-17 19:11:30 | Re: <> join selectivity estimate question |
| Previous Message | Tom Lane | 2017-03-17 19:04:12 | Re: [COMMITTERS] pgsql: Use asynchronous connect API in libpqwalreceiver |