| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Spurious "apparent wraparound" via SimpleLruTruncate() rounding |
| Date: | 2021-01-02 07:31:45 |
| Message-ID: | 25719B7D-080D-45C6-9A62-2320D8E6DFC7@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> 2 янв. 2021 г., в 01:35, Noah Misch <noah(at)leadboat(dot)com> написал(а):
> There's no
> other connection to this thread, and one can review patches on this thread
> without studying commit c732c3f.
OK, thanks!
Do I understand correctly that this is bugfix that needs to be back-patched?
Thus we should not refactor 4 identical *PagePrecedes(int page1, int page2) into 1 generic function?
Since functions are not symmetric anymore, maybe we should have better names for arguments than "page1" and "page2"? At least in dev branch.
Is it common practice to embed tests into assert checking like in SlruPagePrecedesUnitTests()?
SLRU seems no near simple, BTW. The only simple place is naive caching algorithm. I remember there was a thread to do relations from SLRUs.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-01-02 07:36:51 | Re: faster ETL / bulk data load for heap tables |
| Previous Message | Thomas Munro | 2021-01-02 06:55:25 | Re: psql \df choose functions by their arguments |