| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Ilya Gladyshev <ilya(dot)v(dot)gladyshev(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Progress report of CREATE INDEX for nested partitioned tables |
| Date: | 2023-03-14 14:46:00 |
| Message-ID: | 2571115.1678805160@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> The idea would be for:
> 1) TOTAL to show the number of direct and indirect leaf partitions;
> 2) update progress while building direct or indirect indexes;
> 3) ATTACHing intermediate partitioned tables to increment by 0;
> 4) ATTACHing a direct child should continue to increment by 1,
> since that common case already works as expected and shouldn't be
> changed.
OK.
> The only change from the current patch is (3). (1) still calls
> count_leaf_partitions(), but only once. I'd prefer that to rearranging
> the progress reporting to set the TOTAL in ProcessUtilitySlow().
I don't agree with that. find_all_inheritors is fairly expensive
and it seems completely silly to do it twice just to avoid adding
a parameter to DefineIndex.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2023-03-14 14:47:01 | Re: doc: mentioned CREATE+ATTACH PARTITION as an alternative to CREATE TABLE..PARTITION OF |
| Previous Message | Matthias van de Meent | 2023-03-14 14:41:58 | Re: Ignoring BRIN for HOT updates (was: -udpates seems broken) |