| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add sql_drop event for event triggers |
| Date: | 2013-04-09 15:59:10 |
| Message-ID: | 2565.1365523150@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> I think it would be difficult and probably dangerous to have PG_TRY
>> for only some utility commands, so not much to be done about that.
>> The main thing is to not invoke event trigger code for BEGIN/ABORT/SET.
> What about splitting the big switch statement into two of them? The
> first one for transaction control statements, and then the other bigger
> one.
Sounds like considerable uglification to fix a performance issue that's
entirely hypothetical... let's see some numbers that prove it's worth
worrying about before we do that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-04-09 16:07:34 | Re: [COMMITTERS] pgsql: Add sql_drop event for event triggers |
| Previous Message | Dimitri Fontaine | 2013-04-09 15:56:01 | Re: [COMMITTERS] pgsql: Add sql_drop event for event triggers |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-04-09 16:07:34 | Re: [COMMITTERS] pgsql: Add sql_drop event for event triggers |
| Previous Message | Dimitri Fontaine | 2013-04-09 15:56:01 | Re: [COMMITTERS] pgsql: Add sql_drop event for event triggers |