Re: Bogus tags for comments, ACLs, and security labels in pg_dump

I wrote:
> What I think we should do is fix pg_dump so that these classes of
> TOC entries do indeed have tags that meet the expectation held by
> _tocEntryRequired, as per the first attached patch.

Some further poking around identified another place that was taking
dubious shortcuts to identify large-object TOC entries, further down
in _tocEntryRequired. Since that code is executed only during
binary upgrade, which will be working from a schema-only dump anyway,
it *might* be harmless. But I'm not sure, and it's certainly far from
future-proof. I also noted a copy-and-pasteo in dumpSecLabel.

Hence, I intend to add the attached to the back-patched fix proposed
previously.

regards, tom lane