Re: [COMMITTERS] pgsql: Add GUC variables to control keep-alive

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Oliver Jowett <oliver(at)opencloud(dot)com>
Cc: Larry Rosenman <ler(at)lerctr(dot)org>, "'Andrew Dunstan'" <andrew(at)dunslane(dot)net>, "'Bruce Momjian'" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "'Rocco Altier'" <RoccoA(at)Routescape(dot)com>, "'PostgreSQL-development'" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add GUC variables to control keep-alive
Date: 2005-07-31 07:30:47
Message-ID: 25517.1122795047@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Oliver Jowett <oliver(at)opencloud(dot)com> writes:
> per my linux/socket.h:

>> /* Setsockoptions(2) level. Thanks to BSD these must match IPPROTO_xxx */
>> #define SOL_IP 0
>> /* #define SOL_ICMP 1 No-no-no! Due to Linux :-) we cannot use SOL_ICMP=1 */
>> #define SOL_TCP 6

> (I won't get into why using wire-level-protocol constants for syscall
> option numbering is a bad idea.. :)

[ raised eyebrow... ] You think the wire protocol numbers are more
likely to change than the syscall assignments? Consider the range of
systems that each change would affect.

Also, that assignment is not mere BSD-ism, it's specified by the Single
Unix Spec, as well as every other document I could lay my hands on
today. Whoever wrote the comments in linux/socket.h is just
clueless.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Oliver Jowett 2005-07-31 10:54:25 Re: [COMMITTERS] pgsql: Add GUC variables to control keep-alive
Previous Message User Llonergan 2005-07-31 05:26:20 bizgres - bizgres: Added -shared for Solaris to take care of gcc

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2005-07-31 08:49:48 Re: Remote administration functionality
Previous Message Alvaro Herrera 2005-07-31 04:48:10 Re: Remote administration functionality