Re: [PATCH] Expand character set for ltree labels

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Garen Torikian <gjtorikian(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Expand character set for ltree labels
Date: 2022-10-05 19:56:24
Message-ID: 2549024.1664999784@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Garen Torikian <gjtorikian(at)gmail(dot)com> writes:
>> Perhaps the docs are a bit unclear about that, but it's not
>> restricted to ASCII alphanumerics. AFAICS the code will accept
>> whatever iswalpha() and iswdigit() will accept in the database's
>> default locale.

> Sorry but I don't think that is correct. Here is the single
> definition check of what constitutes a valid character:
> https://github.com/postgres/postgres/blob/c3315a7da57be720222b119385ed0f7ad7c15268/contrib/ltree/ltree.h#L129

> As you can see, there are no `is_*` calls at all.

Did you chase down what t_isalpha and t_isdigit do?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-10-05 20:07:10 meson PGXS compatibility
Previous Message Tom Lane 2022-10-05 19:53:35 ts_locale.c: why no t_isalnum() test?