Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>, Galy Lee <lee(dot)galy(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit
Date: 2007-06-08 14:54:26
Message-ID: 25462.1181314466@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers pgsql-patches

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Matthew T. O'Connor wrote:
>>> Can you make 0 and -1 both valid disabled values? That way it will be
>>> compatible with previous releases.
>>
>> Heh, sure, we can do that too and it doesn't seem like anybody would
>> object. I will patch the documentation so that that the "disabled"
>> value is zero, and still allow -1. That way it doesn't seem like there
>> should be any objection.

> Patch attached.

It seems like documenting vac_cost_limit as being different from the
others will just create perceived complexity/confusion, with no real
benefit. I'd suggest leaving the documentation and the default value
alone, and applying just the part of the patch that causes 0 to be
silently treated as if it were -1.

A comment at the spot where this is done would be a good idea, but
I don't think we need to say anything in the SGML docs.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2007-06-08 15:00:50 Re: BUG #3326: Invalid lower bound of autovacuum_cost_limit
Previous Message Heikki Linnakangas 2007-06-08 14:46:29 Re: BUG #3376: Erro : COMMIT

Browse pgsql-hackers by date

  From Date Subject
Next Message Zeugswetter Andreas ADI SD 2007-06-08 14:57:59 Re: Autovacuum launcher doesn't notice death of postmaster immediately
Previous Message Alvaro Herrera 2007-06-08 14:41:42 Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

Browse pgsql-patches by date

  From Date Subject
Next Message Zeugswetter Andreas ADI SD 2007-06-08 14:57:59 Re: Autovacuum launcher doesn't notice death of postmaster immediately
Previous Message Alvaro Herrera 2007-06-08 14:41:42 Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit