Re: Boatload of warnings in CVS HEAD :-(

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Hannes Eder" <Hannes(at)HannesEder(dot)net>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Boatload of warnings in CVS HEAD :-(
Date: 2007-05-03 21:14:30
Message-ID: 25398.1178226870@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Hannes Eder" <Hannes(at)HannesEder(dot)net> writes:
> Tome Lane wrote:
>> We can fix this for gcc by putting __attribute__((noreturn)) on the
>> declaration of pg_re_throw(), but what about other compilers?

> For MSVC 2005 use __declspec(noreturn) (see [1]). I think this also work for some older versions of MSVC.

It might be too messy to try to do this for all compilers. I thought of
a plan B, which is to make PG_RE_THROW() expand as

pg_re_throw(), exit(1)

which should be enough to persuade any compiler that understands the
concept at all. Comments?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jaba the mobzy 2007-05-03 21:33:23 Bitmap Heap Scan anomaly
Previous Message Hannes Eder 2007-05-03 21:09:19 Re: Boatload of warnings in CVS HEAD :-(