| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory |
| Date: | 2005-06-06 13:56:30 |
| Message-ID: | 25394.1118066190@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> You realize this is a waste of code, no?
> I guess, but the person reported a leak so I figured I would fix it.
I don't really care whether there's a free() there or not --- what
bothers me is that calling it a leak shows a fundamental
misunderstanding of the environment in which that code runs, which
is likely to lead to proposed changes that have less trivial
consequences.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Markus Bertheau ☭ | 2005-06-06 14:17:24 | Re: ARRAY() returning NULL instead of ARRAY[] resp. {} |
| Previous Message | Bruce Momjian | 2005-06-06 13:35:54 | Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Markus Bertheau ☭ | 2005-06-06 14:17:24 | Re: ARRAY() returning NULL instead of ARRAY[] resp. {} |
| Previous Message | Bruce Momjian | 2005-06-06 13:35:54 | Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory |