| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Run pgindent now? |
| Date: | 2015-05-25 19:20:47 |
| Message-ID: | 25375.1432581647@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Mon, May 25, 2015 at 03:12:24PM -0400, Tom Lane wrote:
>> The point is for the back branches to absorb pgindent-induced changes that
>> have already happened in HEAD, so I'm not sure what you're getting at.
> My point is uses of new typedefs names added in HEAD which are not
> typedefs in the back branches will be pgindent'ed differently than
> before, e.g. back branches use a variable 'aaa' which is not a typedef
> in back branches, but if 'aaa' becomes a typedef in HEAD, references to
> 'aaa' in back branches will be adjusted by pgindent.
Right, and that's what we want, because the corresponding uses of 'aaa'
as a variable will also have been changed in HEAD. The point of this
exercise is to ensure that otherwise-equivalent code is indented the same
in all branches.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2015-05-25 19:35:00 | Re: [Pgbuildfarm] buildfarm olinguito vs python |
| Previous Message | Bruce Momjian | 2015-05-25 19:16:15 | Re: Run pgindent now? |