| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | NikhilS <nikkhils(at)gmail(dot)com> |
| Cc: | "Neil Conway" <neilc(at)samurai(dot)com>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Trevor Hardcastle" <chizu(at)spicious(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| Date: | 2007-05-03 05:24:45 |
| Message-ID: | 25321.1178169885@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
NikhilS <nikkhils(at)gmail(dot)com> writes:
> Hi Neil,
>> * the patch is broken for expressional indexes, and silently omits
>> copying the predicate that may be associated with an index.
> Since this patch is only supposed to copy unique/primary indexes, I dont
> think we will ever have predicates associated to such indexes?
Huh? I would expect a clause "INCLUDING INDEXES" to mean copying *all*
indexes. A clause "INCLUDING CONSTRAINTS" would reasonably act as you
suggest, ie copy only indexes derived from SQL constraint clauses.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-05-03 05:30:39 | Re: Feature freeze progress report |
| Previous Message | Mark Kirkwood | 2007-05-03 04:56:59 | Re: Updated bitmap index patch |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2007-05-03 05:49:39 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| Previous Message | Mark Kirkwood | 2007-05-03 04:56:59 | Re: Updated bitmap index patch |