Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Date: 2019-06-19 21:35:48
Message-ID: 25314.1560980148@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Jun 17, 2019 at 2:41 PM Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>> Ah, ok, I agree that would have been good to do. Of course, hindsight
>> being 20/20 and all that. Something to keep in mind for the future
>> though.

> I think it was inappropriate to commit this at all. You can't just
> say "some other committer objects, but I think I'm right so I'll just
> ignore them and commit anyway." If we all do that it'll be chaos.

FWIW, that was my concern about this.

> I don't know exactly how many concurring vote it takes to override
> somebody else's -1, but it's got to be more than zero.

If even one other person had +1'd Andrew's proposal, I'd have yielded
to the consensus --- this was certainly an issue on which it's not
totally clear what to do. But unless I missed some traffic, the vote
was exactly 1 to 1. There is no way that that represents consensus to
commit.

Also on the topic of process: 48 hours before a wrap deadline is
*particularly* not the time to play fast and loose with this sort of
thing. It'd have been better to wait till after this week's releases,
so there'd at least be time to reconsider if the patch turned out to
have unexpected side-effects.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-06-19 22:47:38 Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Previous Message Robert Haas 2019-06-19 21:26:18 Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-06-19 21:45:05 Re: more Unicode data updates
Previous Message Robert Haas 2019-06-19 21:26:18 Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)