| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>, Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>, Pgsql-Cygwin <pgsql-cygwin(at)postgresql(dot)org>, Michael Lemke <lemkemch(at)t-online(dot)de> |
| Subject: | Re: [PATCHES] Cygwin PostgreSQL ESQL Patch |
| Date: | 2001-05-03 16:15:46 |
| Message-ID: | 25282.988906546@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-cygwin pgsql-patches |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Please commit and wrap ahead. IMO, the #ifdef DLLIMPORT should stay in
> sqlca.h, but the #ifdef __CYGWIN__ should probably outside of it (not
> inside).
Huh? The macro has to get defined as *something* --- for non-CYGWIN
it must become defined as empty. Jason's code looks OK to me.
I applied the patch as it stood ... if you think you can improve the
style then go ahead ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jason Tishler | 2001-05-03 16:56:21 | Re: [PATCHES] Cygwin PostgreSQL ESQL Patch |
| Previous Message | Peter Eisentraut | 2001-05-03 14:38:30 | Re: [PATCHES] Cygwin PostgreSQL ESQL Patch |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jason Tishler | 2001-05-03 16:56:21 | Re: [PATCHES] Cygwin PostgreSQL ESQL Patch |
| Previous Message | Peter Eisentraut | 2001-05-03 14:38:30 | Re: [PATCHES] Cygwin PostgreSQL ESQL Patch |