| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Bernd Helmle <mailings(at)oopsware(dot)de> |
| Subject: | Re: [HACKERS] Deadlock in XLogInsert at AIX |
| Date: | 2019-08-31 18:27:55 |
| Message-ID: | 2525.1567276075@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> Done. fetch-add-variable-test-v1.patch just adds tests for non-constant
> addends and 16-bit edge cases. Today's implementation handles those,
> PostgreSQL doesn't use them, and I might easily have broken them.
> fetch-add-xlc-asm-v1.patch moves xlc builds from the __fetch_and_add()
> intrinsic to inline asm. fetch-add-gcc-xlc-unify-v1.patch moves fetch_add to
> inline asm for all other ppc compilers. gcc-7.2.0 generates equivalent code
> before and after. I plan to keep the third patch HEAD-only, back-patching the
> other two. I tested with xlc v12 and v13.
Hm, no objection to the first two patches, but I don't understand
why the third patch goes to so much effort just to use "addi" rather
than (one assumes) "li" then "add"? It doesn't seem likely that
that's buying much.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ibrar Ahmed | 2019-08-31 19:40:28 | Re: block-level incremental backup |
| Previous Message | Paul A Jungwirth | 2019-08-31 13:35:48 | Re: range bug in resolve_generic_type? |