Re: _WINSOCK_DEPRECATED_NO_WARNINGS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Glen Knowles <gknowles(at)ieee(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: _WINSOCK_DEPRECATED_NO_WARNINGS
Date: 2017-11-17 03:46:55
Message-ID: 25237.1510890415@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Glen Knowles <gknowles(at)ieee(dot)org> writes:
> On Thu, Nov 16, 2017 at 8:37 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> but evidently it chose the wrong cutoff for when to enable that
>> symbol, because woodlouse is (or claims to be) running VS2013.

> It's actually checking the wrong thing, the problem is the version of the
> Windows SDK, and while the one installed by default with VS2015 might be
> the right place to cutoff it's not uncommon to have multiple versions of
> the SDK (and VS) in various combinations.

Ah, interesting point --- though it's not clear that woodlouse is actually
running a mixture of SDK/VS releases.

> Or you could just define it unconditionally. :)

Already done that way.

I wonder though if this means the other tests of _MSC_VER in our tree
are wrong?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2017-11-17 04:13:49 Re: [HACKERS] Improve catcache/syscache performance.
Previous Message Fabrízio de Royes Mello 2017-11-17 03:38:01 Re: [HACKERS] [PATCH] A hook for session start