| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| Date: | 2016-11-12 17:17:10 |
| Message-ID: | 25236.1478971030@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2016-11-12 11:42:12 -0500, Tom Lane wrote:
>> Hm. What about inventing an additional macro NO_INSTALLCHECK that
>> prevents pgxs.mk from generating an installcheck rule?
> That'd work. I'd also be ok with living with the warning. I have to say
> I find it hard to be concerned about the cycles here. It's not like
> anybody complained about make check unconditionally creating a test
> installation, even if there's tests in a contrib module...
[ shrug... ] The reason why the buildfarm doesn't do "make check" here is
precisely the extra cycles it would take. Those add up over hundreds of
runs, particularly on slow machines. So I'm not excited about running
completely useless operations.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2016-11-13 13:25:12 | pgsql: pg_stat_statements: Add .gitignore file for tests |
| Previous Message | Andres Freund | 2016-11-12 17:12:25 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-11-12 17:28:18 | Re: Indirect indexes |
| Previous Message | Andres Freund | 2016-11-12 17:12:25 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |