| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Move pg_dump memory routines into pg_dumpmem.c/h and restore com |
| Date: | 2011-11-27 17:42:59 |
| Message-ID: | 25134.1322415779@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> MSVC is still broken with this change, but now I think we've exposed a
> long-standing error in the MSVC build system. ...
> AddSimpleFrontend() calls AddDir() which harvests the contents of
> $(OBJS) from the Makefile for the target. But pg_dumpall doesn't want
> $(OBJS). We've been benignly but mistakenly building it with them for a
> quite a few years, but now we can't do that any more, given Bruce's
> changes. It looks like the fix is to call AddProject() for pg_dumpall
> instead of AddSimpleFrontend() and then do a little more work ourselves
> to select exactly what we need.
Maybe it would be better to refactor the makefile so that $(OBJS) is
still sensible to use this way?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-11-27 17:57:20 | pgsql: Use the proper macro to convert a bool to a Datum. |
| Previous Message | Andrew Dunstan | 2011-11-27 14:23:16 | Re: pgsql: Move pg_dump memory routines into pg_dumpmem.c/h and restore com |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-11-27 17:57:44 | Re: small cleanup pl_exec.c |
| Previous Message | Tom Lane | 2011-11-27 17:29:02 | Re: GiST range-contained-by searches versus empty ranges |