Re: [PATCHES] snprintf() argument reordering not working

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, ntufar(at)gmail(dot)com, devrim(at)kivi(dot)com(dot)tr, mha(at)sollentuna(dot)net, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] snprintf() argument reordering not working
Date: 2005-12-06 05:08:35
Message-ID: 25116.1133845715@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Also, we need a way to stop this from happening all over the build:

> In file included from ../../../../../../src/include/c.h:820,
> from ../../../../../../src/include/postgres.h:48,
> from utf8_and_sjis.c:14:
> ../../../../../../src/include/port.h:121: warning: `libintl_printf' is an unrecognized format function type

Argh, I ordered things wrong: should undef the old macros before
declaring the new functions.

Not sure why my build didn't show the problem in pgtypeslib, though.
That should have failed with or without libintl macros.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2005-12-06 05:19:35 Re: [PATCHES] snprintf() argument reordering not working
Previous Message Bruce Momjian 2005-12-06 04:59:10 Re: Reduce NUMERIC size by 2 bytes, reduce max length to 508

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2005-12-06 05:19:35 Re: [PATCHES] snprintf() argument reordering not working
Previous Message Bruce Momjian 2005-12-06 04:59:10 Re: Reduce NUMERIC size by 2 bytes, reduce max length to 508