Re: [Patch] timezone/zic.c: Fix file handle leak in dolink()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: zengman <zengman(at)halodbtech(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Patch] timezone/zic.c: Fix file handle leak in dolink()
Date: 2025-12-28 16:59:25
Message-ID: 2510832.1766941165@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"=?ISO-8859-1?B?emVuZ21hbg==?=" <zengman(at)halodbtech(dot)com> writes:
> Furthermore, I noticed that some of the test code in `contrib/pg_trgm/trgm_regexp.c` does not check the return value of the `fopen()` call.
> I'm not sure if it's necessary to make the modification.

Probably not worth the trouble. This is barely even debug-grade
code, seeing that there's no provision to change the target file
name. It's clearly not meant for use in unfriendly environments.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-12-28 17:15:28 Re: Get rid of "Section.N.N.N" on DOCs
Previous Message Tom Lane 2025-12-28 16:56:03 Re: [Patch] timezone/zic.c: Fix file handle leak in dolink()