Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: 2020-01-04 23:39:34
Message-ID: 25068.1578181174@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> Tom just advised me via private e-mail that my termcap database may be
> the issue here. Looks like he was right. I did a "sudo aptitude
> reinstall ncurses-base", and now the tests pass against HEAD. (I
> probably should have tried to preserve things before going ahead with
> that, but that didn't happen -- I had no reason to think that the
> system was affected by any kind of corruption.)

Hm, well, HEAD still has the hackery with explicit accounting for
escape sequences. Could you try it with the patch I showed to unset
TERM and remove that stuff? (It won't apply exactly to HEAD, but
the diffs are simple enough, or you could revert to 60ab7c80b first.)

> I am very sorry for having wasted your time on this wild goose chase,

Don't worry about it --- even if it was some upgrade glitch, there
was no way to know that in advance.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2020-01-05 00:09:04 Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Previous Message Peter Geoghegan 2020-01-04 23:29:13 Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2020-01-04 23:54:15 Re: parallel vacuum options/syntax
Previous Message Peter Geoghegan 2020-01-04 23:29:13 Re: pgsql: Add basic TAP tests for psql's tab-completion logic.