Re: table/index fillfactor control

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: table/index fillfactor control
Date: 2006-06-07 02:48:55
Message-ID: 25057.1149648535@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> "Jonah H. Harris" <jonah(dot)harris(at)gmail(dot)com> wrote:
>> There's 4 shift/reduce conflicts which I believe are caused by having
>> used WITH... did you plan to fix this?

> Thanks for pointing out. I realized it is a confliction between
> WITH OIDS and WITH (options).

> I'll try to treat CreateStmt.hasoids as one of the options internally,
> with SQL-level backward compatibility.

There was some discussion recently about how we'll have to make WITH
a fully reserved keyword eventually anyway to handle SQL99 recursive
queries. I'm not sure if that's really true, but reserving WITH is
a fallback position we should consider, if avoiding the shift/reduce
conflict seems unreasonably messy otherwise.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Woodward 2006-06-07 03:09:08 Re: AGREGATE FUNCTIONS
Previous Message Tom Lane 2006-06-07 02:39:43 Re: That EXPLAIN ANALYZE patch still needs work

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-06-07 03:22:10 Re: [HACKERS] Win32 sysconfig -> pg_service.conf
Previous Message ITAGAKI Takahiro 2006-06-07 01:42:54 Re: table/index fillfactor control