From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Compiler warnings with --enable-dtrace |
Date: | 2018-05-07 17:10:06 |
Message-ID: | 25055.1525713006@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I wrote:
> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
>> Maybe we should do what the Perl people do[2] and post-process the
>> generated header file to add const qualifiers? Please see attached.
> +1 for the idea. I notice that Perl's version of this is careful
> not to munge lines that already contain "const" ... do we need to
> worry about that?
Oh, I take that back --- on closer look, I see that you're getting
the same effect by checking for a preceding paren or comma. That's
arguably better than their way because it works if there's a mix of
const and not-const parameters on one input line, though likely no
dtrace implementation actually emits such things.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2018-05-07 17:23:32 | Re: [HACKERS] Parallel Append implementation |
Previous Message | Tom Lane | 2018-05-07 17:07:15 | Re: make installcheck-world in a clean environment |