Re: libpq: PQgetCopyData() and allocation overhead

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jelte Fennema <postgres(at)jeltef(dot)nl>
Cc: Jeroen Vermeulen <jtvjtv(at)gmail(dot)com>, daniel(at)yesql(dot)se, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: libpq: PQgetCopyData() and allocation overhead
Date: 2023-03-03 17:55:16
Message-ID: 2505190.1677866116@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jelte Fennema <postgres(at)jeltef(dot)nl> writes:
> On Fri, 3 Mar 2023 at 17:33, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> If you mean exposing PQExpBuffer to users of libpq-fe.h, I'd be very
>> seriously against that. I realize that libpq exposes it at an ABI
>> level, but that doesn't mean we want non-Postgres code to use it.

> The code comment in the pqexpbuffer.h header suggests that client
> applications are fine too use the API to:

Our own client apps, sure. But you have to buy into the whole Postgres
compilation environment to use PQExpBuffer. (If you don't believe me,
just try including pqexpbuffer.h by itself.) That's a non-starter
for most clients.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2023-03-03 17:56:23 Re: pgsql: Harden new test case against force_parallel_mode = regress.
Previous Message Robert Haas 2023-03-03 17:53:10 Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete