| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Replace open mode with PG_BINARY_R/W/A macros |
| Date: | 2022-04-19 06:20:33 |
| Message-ID: | 2503493.1650349233@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Japin Li <japinli(at)hotmail(dot)com> writes:
> On Mon, 18 Apr 2022 at 22:41, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> A lot of these changes look wrong to me: they are substituting "rb" for
>> "r", etc, in places that mean to read text files. You have to think
>> about the Windows semantics.
> I do this substituting, since the comment says it can be used for opening
> text files. Maybe I misunderstand the comment.
I think the comment's at best misleading. See e.g. 66f8687a8.
It might be okay to use "rb" to read a text file when there
is actually \r-stripping logic present, but you need to check
that. Using "wb" to write a text file is flat wrong.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-04-19 06:57:55 | Re: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Michael Paquier | 2022-04-19 06:14:27 | Re: Replace open mode with PG_BINARY_R/W/A macros |