Re: Fixing WAL instability in various TAP tests

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Cc: Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fixing WAL instability in various TAP tests
Date: 2021-09-25 14:17:47
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> writes:
>> On Sep 24, 2021, at 10:21 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
>>> I would
>>> expect tests which fail under legal alternate GUC settings to be hardened to
>>> explicitly set the GUCs as they need, rather than implicitly relying on the
>>> defaults.

>> That is not the general practice in PostgreSQL tests today. The buildfarm
>> exercises some settings, so we keep the tests clean for those. Coping with
>> max_wal_size=2 that way sounds reasonable. I'm undecided about the value of
>> hardening tests against all possible settings.

> Leaving the tests brittle wastes developer time.

Trying to make them proof against all possible settings would waste
a lot more time, though.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2021-09-25 14:44:52 Re: rand48 replacement
Previous Message Mark Dilger 2021-09-25 14:12:08 Re: Fixing WAL instability in various TAP tests