Re: missing indexes in indexlist with partitioned tables

From: Arne Roland <A(dot)Roland(at)index(dot)de>
To: Amit Langote <amitlangote09(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com>
Subject: Re: missing indexes in indexlist with partitioned tables
Date: 2022-10-01 16:34:16
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Sep 20, 2022 at 4:53 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> Arne sent me an off-list
> message to say he's planning on working on the patch that uses the
> existing field instead of the new one he originally added. Let's hold
> off for that patch.

I wouldn't say, I explicitly stated that. But I ended up doing something, that resulted in the attached patch. :)

For my own sanity I greped one last time for the usage of indexlist.

Most of the (untouched) usages have comments that, they are only called for baserels/plain tables.

Namely all but the cluster of partitioned tables. I had to reread that section. There we are just traversing the tree and omitting partitioned tables.

There is now a test section in join.sql for partitioned tables, that tests very similar to the

baserel case. That's more thorough, than what I originally went for.

Further feedback would be appreciated!


Attachment Content-Type Size
v8_indexlist_contains_partitioned_indexes-0001-v8.patch text/x-patch 26.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2022-10-01 16:35:31 Re: pgsql: Avoid improbable PANIC during heap_update.
Previous Message Justin Pryzby 2022-10-01 16:14:20 Re: longfin and tamandua aren't too happy but I'm not sure why