PG version is not shown in pg_upgrade test log

From: Потапов Александр <a(dot)potapov(at)postgrespro(dot)ru>
To: pgsql-hackers(at)postgresql(dot)org
Subject: PG version is not shown in pg_upgrade test log
Date: 2025-10-23 08:20:05
Message-ID: 24b029-68f9e500-1-4154a880@137427684
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hi hackers!

I ran pg_upgrade tests (make check -C src/bin/pg_upgrade) and found that test log does not contain PG version:
   (file: src/bin/pg_upgrade/tmp_check/log/regress_log_002_pg_upgrade)
   Name: old_node
   Data directory: /home/dev/code/postgrespro3/src/bin/pg_upgrade/tmp_check/t_002_pg_upgrade_old_node_data/pgdata
   Backup directory: /home/dev/code/postgrespro3/src/bin/pg_upgrade/tmp_check/t_002_pg_upgrade_old_node_data/backup
This happens because $node->_set_pg_version is called after invocation of $node->dump_info. To fix it we should change line order in Cluster.pm file. The result looks like:
   Name: old_node
   Version: 19devel
   Data directory: /home/dev/code/postgrespro3/src/bin/pg_upgrade/tmp_check/t_002_pg_upgrade_old_node_data/pgdata
   Backup directory: /home/dev/code/postgrespro3/src/bin/pg_upgrade/tmp_check/t_002_pg_upgrade_old_node_data/backup
 
The change I suggest is:
   --- a/src/test/perl/PostgreSQL/Test/Cluster.pm
   +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
   @@ -1647,10 +1647,10 @@ sub new
           or
           BAIL_OUT("could not create data directory \"$node->{_basedir}\": $!");
   -    $node->dump_info;
   -
       $node->_set_pg_version;

   +    $node->dump_info;
   +
       my $ver = $node->{_pg_version};

       # Use a subclass as defined below (or elsewhere) if this version
 
Patch attached.

Best regards,
Alexander Potapov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
0001-Show-PG-version-in-pg_upgrade-test-log.patch application/octet-stream 854 bytes

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-10-23 08:22:27 Re: Docs and tests for RLS policies applied by command type
Previous Message Fujii Masao 2025-10-23 08:19:49 Re: Make wal_receiver_timeout configurable per subscription